Merge any marker constraints into constraints with specific markers#4590
Merged
neersighted merged 1 commit intopython-poetry:masterfrom Nov 21, 2021
Conversation
7fec712 to
7bacea5
Compare
7bacea5 to
53dfb8a
Compare
neersighted
approved these changes
Nov 21, 2021
Merged
This was referenced Nov 25, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #4516
If there are several requirements for the same library, requirements with markers can be considered as additions to requirements without markers.
For example see this extract from the install_requires of black 21.9b0:
These statements define that typing_extensions has to be at least 3.10.0.0 for all python versions (including python 3.10 and above). Additionally, typing_extensions for python 3.10 and above must not be 3.10.0.1.
Thus, the constraints of requirements without markers have to be merged into the constraints of requirements with markers.