Rename whitelist_externals in FAQ#4574
Merged
neersighted merged 4 commits intopython-poetry:masterfrom Nov 11, 2021
wwuck:patch-1
Merged
Rename whitelist_externals in FAQ#4574neersighted merged 4 commits intopython-poetry:masterfrom wwuck:patch-1
neersighted merged 4 commits intopython-poetry:masterfrom
wwuck:patch-1
Conversation
`whitelist_externals` is now deprecated in tox and has been renamed to `allowlist_externals` https://tox.readthedocs.io/en/latest/config.html#conf-allowlist_externals
Member
|
@wwuck maybe a good idea to update our |
whitelist_externals is now deprecated in tox and has been renamed to allowlist_externals https://tox.readthedocs.io/en/latest/config.html#conf-allowlist_externals
Contributor
|
I think the minimum Line 59 in 82459bd |
Contributor
|
I think this line should also say tox >= 3.18 Line 2 in 82459bd |
Mariatta
suggested changes
Oct 13, 2021
Contributor
Mariatta
left a comment
Mariatta
left a comment
There was a problem hiding this comment.
The minimum tox version should be changed to >= 3.18 where the allowlist_externals got introduced.
Specify minimum tox version for allowlist_externals
Contributor
Author
|
@Mariatta Please review again |
neersighted
approved these changes
Nov 11, 2021
Member
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
LGTM! Thanks for bumping the version and fixing our config.
1nF0rmed
pushed a commit
to 1nF0rmed/poetry
that referenced
this pull request
Nov 15, 2021
`whitelist_externals` is now deprecated in Tox >= 3.18 and has been renamed to `allowlist_externals` https://tox.readthedocs.io/en/latest/config.html#conf-allowlist_externals
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whitelist_externalsis now deprecated in tox and has been renamed toallowlist_externalshttps://tox.readthedocs.io/en/latest/config.html#conf-allowlist_externals