[1.1] Ensure all hash types are checked#4529
Merged
Conversation
sdispater
added
kind/bug
sdispater
force-pushed
the
1.1-ensure-all-hash-types-are-checked
branch
from
14c8da8 to
2c1a86b
Compare
3 tasks
2 tasks
awilkins
reviewed
Sep 21, 2021
awilkins
left a comment
awilkins
left a comment
There was a problem hiding this comment.
Looks good, better mocking than my tests (you've definitely had more practice..). Reckon using the match for pytest.raises() would be neater.
| if archive_hashes.isdisjoint(hashes): | ||
| raise RuntimeError( | ||
| "Invalid hash for {} using archive {}".format(package, archive.name) | ||
| "Invalid hashes ({}) for {} using archive {}. Expected one of {}.".format( |
There was a problem hiding this comment.
I like this better than my single hash message.
sdispater
force-pushed
the
1.1-ensure-all-hash-types-are-checked
branch
4 times, most recently
from
89c9d9c to
43b7c61
Compare
sdispater
force-pushed
the
1.1-ensure-all-hash-types-are-checked
branch
from
43b7c61 to
5221df9
Compare
Merged
neersighted
added a commit
that referenced
this pull request
Nov 13, 2021
neersighted
added a commit
that referenced
this pull request
Nov 13, 2021
neersighted
added a commit
that referenced
this pull request
Nov 13, 2021
neersighted
added a commit
that referenced
this pull request
Nov 13, 2021
neersighted
added a commit
that referenced
this pull request
Nov 13, 2021
neersighted
added a commit
that referenced
this pull request
Nov 13, 2021
neersighted
added a commit
that referenced
this pull request
Nov 15, 2021
neersighted
added a commit
that referenced
this pull request
Nov 16, 2021
neersighted
added a commit
that referenced
this pull request
Nov 19, 2021
Closed
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #4523