respect hash algorithm when verifying downloaded archives.#4486
respect hash algorithm when verifying downloaded archives.#4486kaos wants to merge 2 commits intopython-poetry:masterfrom
Conversation
Signed-off-by: Andreas Stenius <[email protected]>
neersighted
left a comment
neersighted
left a comment
There was a problem hiding this comment.
Hey @kaos -- this looks good in light of the past state of the master branch, but things have changed... A fusion of your (and the other PR) to poetry-core has landed, and another PR has factored out the hash checking code. Could you rebase your changes/new tests on top of those? I'd like to get this landed to fix Artifactory support.
|
Should close #4578 as well. |
|
It would be more effective if someone who knows the code does this. I'm not up to speed with what changes have been made, nor what changes I made any more. |
|
Sounds good. I'll likely leave this open until I (or someone else) create a new PR on top of the recent refactors. |
This allows for much-improved compatibility when interfacing with legacy PyPI-compatible repositories. This is a successor PR to #4486, and closes #4578 and #4085. Co-authored-by: Andreas Stenius <[email protected]>
|
Successor PR (#4740) created! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
Signed-off-by: Andreas Stenius [email protected]
Resolves: #4085
Depends on python-poetry/poetry-core#196, so marked as draft until there is a new poetry-core version we can use here.