Merged
Conversation
sdispater
added
area/solver
sdispater
force-pushed
the
dependency-groups
branch
3 times, most recently
from
2d453e0 to
60159be
Compare
|
SonarCloud Quality Gate failed.
|
sbast
reviewed
Jul 14, 2021
Leonardofreua
suggested changes
Jul 21, 2021
| not_found = set(packages).difference(removed) | ||
| if not_found: | ||
| raise ValueError( | ||
| "The following packages were not found: {}".format( |
Contributor
There was a problem hiding this comment.
Suggested change
| "The following packages were not found: {}".format( | |
| f"The following packages were not found: {', '.join(sorted(not_found))}" |
| """ | ||
| Removing without specifying a group removes packages from all groups. | ||
| """ | ||
| installed.add_package(Package("foo", "2.0.0")) |
Contributor
There was a problem hiding this comment.
What do you think about maybe creating constants for the strings baz, foo, 1.0.0, and 2.0.0, since they are repeated so often?
If you agree, you will need to change the other test files that use these same values.
| installer.with_groups(["dev"]) | ||
| installer.run() | ||
|
|
||
| assert 0 == installer.executor.installations_count |
Contributor
There was a problem hiding this comment.
Maybe create a constant for the value 0?
| lock-version = "1.1" | ||
| python-versions = "*" | ||
| content-hash = "115cf985d932e9bf5f540555bbdd75decbb62cac81e399375fc19f6277f8c1d8" | ||
| content-hash = "178f2cd01dc40e96be23a4a0ae1094816626346346618335e5ff4f0b2c0c5831" |
Contributor
There was a problem hiding this comment.
It would be interesting to create a constant for content-hash. Here we see an example that if it had a constant, it would not be necessary to make 7 changes to the same value.
sdispater
force-pushed
the
dependency-groups
branch
from
60159be to
5c5af42
Compare
2 tasks
2 tasks
Merged
Closed
3 tasks
2 tasks
5 tasks
mpeteuil
added a commit
to mpeteuil/poetry-dotenv-plugin
that referenced
this pull request
Jul 16, 2023
Poetry first switched from dev dependencies [to dependency groups](python-poetry/poetry#4260) in version [1.2.0a2](https://github.com/python-poetry/poetry/blob/master/CHANGELOG.md#120a2---2021-08-01). The dev dependencies are currently deprecated and will be removed at some point, so this change switches to the new groups configuration. For more information about dependency groups, see [the section in the official documentation](https://python-poetry.org/docs/master/managing-dependencies#dependency-groups).
lukehsiao
added a commit
to lukehsiao/poetry-udeps
that referenced
this pull request
Aug 8, 2023
Poetry 1.2+ includes a new organization for dev dependencies. This patch checks both locations, starting with the pre-1.2 location. Ref: python-poetry/poetry#4260 Closes: #1
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for dependency groups to have a more granular organization of dependencies.
For a complete list of changes and improvements you can refer to the updated documentation in this PR.
Pull Request Check List
Resolves: #1644