Closed
Conversation
sdispater
force-pushed
the
wheel-installer-and-builder
branch
from
5f126d0 to
ddbb94e
Compare
|
SonarCloud Quality Gate failed.
|
sdispater
force-pushed
the
wheel-installer-and-builder
branch
6 times, most recently
from
9be3b0f to
b79fb1a
Compare
sdispater
force-pushed
the
wheel-installer-and-builder
branch
from
b79fb1a to
fc3ce7c
Compare
Contributor
These come from setuptools reusing the same build directory for performing builds and not having any concurency protections. These race conditions exist in newer versions of pip as well, when building in parallel, since pip has switched to in-tree builds as well. |
2 tasks
Member
|
Closing since this is superseded. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards getting rid of subprocess calls to
pipfor package installations and removals.The wheel building is handled by https://github.com/pypa/build and the wheel installation is handled by https://github.com/pradyunsg/installer (with modifications to be more lenient).
Note that the wheel building is not parallelized due to race conditions that I am yet to track down (it seems like the issue comes from
buildwhen calling the backend hooks). This is not a blocker though.Overall this speeds up quite a bit the installation times, especially once wheels are cached.
Pull Request Check List