Emit export errors to stderr to prevent invalid output#4110
Emit export errors to stderr to prevent invalid output#4110finswimmer merged 3 commits intopython-poetry:masterfrom
Conversation
An error in export could emit error messages to stdout, causing the requirements.txt output to stdout to be invalid. Fixes python-poetry#4109
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Some tests are failing in tests/console/commands/test_export.py because the output is checked in stdout.
So you have to change tester.io.fetch_output() to tester.io.fetch_error() where needed.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Fixed! I noted that when I ran tests with |
|
@finswimmer This is a simple one, good to merge? Your requested change has been addressed, the remaining test failure looks unrelated ("connection reset by peer") |
|
@colindean: Could you please rebase your branch, to force the checks to run again? |
|
Checks are running now! |
…#4110) * Emit export errors to stderr to prevent invalid output An error in export could emit error messages to stdout, causing the requirements.txt output to stdout to be invalid. Fixes python-poetry#4109 * Looks at stderr for export tests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
An error in export could emit error messages to stdout, causing the requirements.txt output to stdout to be invalid.
Pull Request Check List
Resolves: #4109
N.b. I made this change in GitHub so I did not run tests or add tests to ensure the bad behavior doesn't happen.