Fix for 3.6 with locale not set#4038
Fix for 3.6 with locale not set#4038neersighted merged 1 commit intopython-poetry:masterfrom brandonchinn178:patch-1
Conversation
|
@brandonchinn178 thank for your contribution. However, I do not think this fixes the issue. I was also unable to reproduce the issue with 1.1.6. |
|
You were unable to reproduce running the above command using poetry installed with python 3.6? |
|
Never mind, was using the wrong base container. I can reproduce the error as shown below. podman run --rm -i --entrypoint bash python:3.6 <<EOF
set -xe
python -m pip install -q poetry
unset LANG
poetry --version
poetry new foobar
pushd foobar
poetry add pycowsay
EOFPackage operations: 12 installs, 0 updates, 0 removals
UnicodeEncodeError
'ascii' codec can't encode character '\u2022' in position 2: ordinal not in range(128)
at /usr/local/lib/python3.6/site-packages/clikit/io/output_stream/stream_output_stream.py:24 in write
UnicodeEncodeError
'ascii' codec can't encode character '\u2022' in position 2: ordinal not in range(128)
at /usr/local/lib/python3.6/site-packages/clikit/io/output_stream/stream_output_stream.py:24 in write
Failed to add packages, reverting the pyproject.toml file to its original content. |
|
I can also verify that the error does not occur with this PR. However the tests seem to not like it. podman run --rm -i --entrypoint bash python:3.6 <<EOF
set -xe
python -m pip install -q git+https://github.com/python-poetry/poetry.git@refs/pull/4038/head
unset LANG
poetry --version
poetry new foobar
pushd foobar
poetry add pycowsay
EOF |
|
@abn any progress on this? |
|
Looks like tests are still failing -- any interest in continuing work on this and getting it merged? |
|
The tests for 3.7+ were broken here: b6e2440. Do I need to fix those? I'll look at the 3.6 failure |
|
|
Done |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #3412
I manually tested this by first installing the version of
poetryonmaster, then running:This should fail. Then making the change I did here and rerunning the above works.
Not sure what tests or docs should be updated, if any.