Conversation
sdispater
added
area/installer
abn
requested changes
Apr 3, 2021
.../fixtures/installed/lib/python3.7/site-packages/file_pep_610-1.2.3.dist-info/direct_url.json
Outdated
Show resolved
Hide resolved
...alled/lib/python3.7/site-packages/editable_directory_pep_610-1.2.3.dist-info/direct_url.json
Outdated
Show resolved
Hide resolved
...ures/installed/lib/python3.7/site-packages/directory_pep_610-1.2.3.dist-info/direct_url.json
Outdated
Show resolved
Hide resolved
sdispater
force-pushed
the
pep-610
branch
2 times, most recently
from
0d203b5 to
897a1ad
Compare
Member
Author
|
@abn Most of your requested changes have been addressed. |
abn
requested changes
Apr 5, 2021
abn
approved these changes
Apr 6, 2021
3 tasks
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for PEP-610 which introduced a standard way of recording the origin of direct URL packages (i.e. file, directory, url and VCS packages).
Two things needed to be done for Poetry to be fully compliant:
direct_url.jsonfile to record the origin of the packagedirect_url.jsonfile inInstalledRepository.load()to retrieve the origin of the information. This also avoids some of the heuristics we are currently doing to guess the origin of the installed packages.One thing of note is that existing environments will see updates for all their "standard" packages due to the fact that
pipalready supports PEP-610 and since we are installing wheels from our own cache,pipconsider them as file packages. That's also why we need to remove thedirect_url.jsonfile generated bypipwhen installing packages. This will be a one-time thing to set the current environments right. New environments will not be affected.Pull Request Check List
Resolves: #2452