Skip to content

Comments

Fix locked VCS dependencies always being updated#3875

Merged
abn merged 2 commits intomasterfrom
fix-locked-vcs-dependecies
Apr 7, 2021
Merged

Fix locked VCS dependencies always being updated#3875
abn merged 2 commits intomasterfrom
fix-locked-vcs-dependecies

Conversation

@sdispater
Copy link
Member

@sdispater sdispater commented Apr 2, 2021 •
edited
Loading

The issue was caused by multiple factors:

  • Every package was marked as "use the latest version" which led to the packages not being retrieved from the locked repository. While this did not matter for "normal" packages this had the unintended side effect of pulling the latest revision of VCS dependencies regardless of the locked version. This was the main problem.
  • Even when the locked version was used, Poetry would still clone VCS dependencies even though it was no longer needed. This is solved by using the Provider.load_deferred(False) since we already have all the information when installing from the lock file.

Pull Request Check List

Resolves: #2921

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater requested a review from a team April 2, 2021 13:42
@abn
Copy link
Member

abn commented Apr 2, 2021 •
edited
Loading

This seems to be partially a dupe of #3867.

@sdispater sdispater mentioned this pull request Apr 4, 2021
Merged
2 tasks
@sdispater
Copy link
Member Author

sdispater commented Apr 4, 2021

This seems to be partially a dupe of #3867.

It's not really a duplicate (except for the checkout of resolved references). This PR actually fixes the issue by using an existing mechanism available in the Provider and by making sure that locked packages are actually used when resolving dependencies against the lock file which was not actually the case up until now.

@abn
Copy link
Member

abn commented Apr 5, 2021

Cirrus tests are failing as they use uncached dependencies. Seems the GHA cached the "latest" master from poetry-core with the 3.10 fix, which was fixed on poetry master via 26a260a. Since this change is fixing the issue, that caused us using an unlocked version of poetry-core git source, we might need to regenerate the lock file with the latest master perhaps?

abn
abn requested changes Apr 5, 2021
View reviewed changes
Copy link
Member

@abn abn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and looks like the cirrus failures is actually due to the fix taking effect. See comment above.

This was referenced Apr 5, 2021
Closed
Closed
@sdispater sdispater force-pushed the fix-locked-vcs-dependecies branch from 179756f to 3eda9d2 Compare April 6, 2021 13:58
@sdispater
Copy link
Member Author

sdispater commented Apr 6, 2021

@abn I updated the lock file with the latest revision of poetry-core

@abn
Copy link
Member

abn commented Apr 6, 2021

@sdispater looks like the PEP-610 changes caused a conflict. Otherwise LGTM

@sdispater sdispater force-pushed the fix-locked-vcs-dependecies branch from 3eda9d2 to 2894542 Compare April 7, 2021 09:45
@sdispater
Copy link
Member Author

sdispater commented Apr 7, 2021

@abn Conflicts are fixed

@abn abn merged commit a12d142 into master Apr 7, 2021
@abn abn deleted the fix-locked-vcs-dependecies branch April 7, 2021 11:06
@sdispater sdispater mentioned this pull request Apr 14, 2021
Merged
@IaroslavR IaroslavR mentioned this pull request Apr 16, 2021
Closed
3 tasks
@sdispater sdispater mentioned this pull request Jun 23, 2021
Merged
2 tasks
@wakemaster39 wakemaster39 mentioned this pull request May 4, 2022
Closed
3 tasks
@dimbleby dimbleby mentioned this pull request Jul 21, 2022
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abn abn abn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

poetry update with git-based dependencies updates poetry.lock but not the virtual environment

2 participants

@sdispater @abn