Properly detect if packages are a git installation over directory installation#3867
Properly detect if packages are a git installation over directory installation#3867sdispater merged 1 commit intopython-poetry:masterfrom
Conversation
|
Thanks for taking the time to make this PR! However, except the checkout of resolved references, I don't think this is the proper fix to this issue. The underlying cause of the problem comes from the fact that locked packages are not used when resolving with the lock file information. See #3875 for a simpler fix that don't require changes to the |
|
@sdispater I have reworked this fix based on the changes in #3875. That PR did not cover all the issues, the last remaining on is on |
|
Could we get this included in the next version of Poetry (if it does work)? It is clear that issue #2921, despite being closed, has not been fixed. |
+1 |
|
This PR solved this issue for me! :) |
|
Is there anything we can do to help merge this or some fix for the git dependencies not updating? |
|
@sdispater When will this fix get released? I saw several releases have been made after this PR being merged, but none of that included this change. Our CI/CD pipeline keeps failing due to this bug so I would like to know whether/when will this fix get included in the upcoming 1.x release. Thank you for your effort. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #2921
This PR supersedes my original work with #2327 to be aligned with the updated code base
There are no tests around the changed code for me to base anything off of for me to get started.
I found no documentation around this, but this is a change in behaviour so not sure where it needs to be documented.