Skip to content

Comments

Properly detect if packages are a git installation over directory installation#3867

Merged
sdispater merged 1 commit intopython-poetry:masterfrom
wakemaster39:git
Jul 11, 2021
Merged

Properly detect if packages are a git installation over directory installation#3867
sdispater merged 1 commit intopython-poetry:masterfrom
wakemaster39:git

Conversation

@wakemaster39
Copy link

@wakemaster39 wakemaster39 commented Mar 31, 2021

Pull Request Check List

Resolves: #2921

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR supersedes my original work with #2327 to be aligned with the updated code base

There are no tests around the changed code for me to base anything off of for me to get started.

I found no documentation around this, but this is a change in behaviour so not sure where it needs to be documented.

@sdispater
Copy link
Member

Thanks for taking the time to make this PR!

However, except the checkout of resolved references, I don't think this is the proper fix to this issue. The underlying cause of the problem comes from the fact that locked packages are not used when resolving with the lock file information.

See #3875 for a simpler fix that don't require changes to the Provider and the InstalledRepository classes.

@wakemaster39
Copy link
Author

@sdispater I have reworked this fix based on the changes in #3875. That PR did not cover all the issues, the last remaining on is on poetry update because the packages are being installed via an editable install it doesn't find the src folder in its paths so it looks like a directory install. This causes poetry to not update the package.

@wakemaster39 wakemaster39 changed the title feat: poetry respects git and git lock Properly detect if packages are a git installation over directory installation Apr 21, 2021
@amanda-wee
Copy link

Could we get this included in the next version of Poetry (if it does work)? It is clear that issue #2921, despite being closed, has not been fixed.

@galamit86
Copy link

Could we get this included in the next version of Poetry (if it does work)? It is clear that issue #2921, despite being closed, has not been fixed.

+1

@nirhal
Copy link

nirhal commented Jul 1, 2021

This PR solved this issue for me! :)
Can you please merge it to the next release?

@DataInformer
Copy link

Is there anything we can do to help merge this or some fix for the git dependencies not updating?

@sdispater sdispater merged commit 5278823 into python-poetry:master Jul 11, 2021
@devunt
Copy link

devunt commented Sep 23, 2021

@sdispater When will this fix get released? I saw several releases have been made after this PR being merged, but none of that included this change. Our CI/CD pipeline keeps failing due to this bug so I would like to know whether/when will this fix get included in the upcoming 1.x release. Thank you for your effort.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

poetry update with git-based dependencies updates poetry.lock but not the virtual environment

7 participants