Skip to content

Comments

Give a clear error message when adding package with the same name as your local package#3841

Merged
finswimmer merged 6 commits intopython-poetry:masterfrom
david-fortini:fix_236
Jan 30, 2022
Merged

Give a clear error message when adding package with the same name as your local package#3841
finswimmer merged 6 commits intopython-poetry:masterfrom
david-fortini:fix_236

Conversation

@david-fortini
Copy link
Contributor

@david-fortini david-fortini commented Mar 27, 2021

Pull Request Check List

Resolves: #236

  • Added tests for changed code.
  • Updated documentation for changed code.

finswimmer
finswimmer requested changes Jul 23, 2021
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @david-fortini 👍

I've added just a small suggestion.

@hagaivcita
Copy link

hagaivcita commented Jan 21, 2022

hi, looks like the tests are passing except some CI procedures which are stuck (runs for 100+ days)
can they be reinitialized so this PR would merge and resolve?

@finswimmer
Copy link
Member

finswimmer commented Jan 21, 2022

Could you please rebase your PR @david-fortini ?

@david-fortini
Copy link
Contributor Author

david-fortini commented Jan 21, 2022

Could you please rebase your PR @david-fortini ?

Yes I will do that in the coming weekend!

@david-fortini
Copy link
Contributor Author

david-fortini commented Jan 24, 2022

Could you please rebase your PR @david-fortini ?

@finswimmer It took some time, I think the PR should be ready now. Let me know if there are more remarks/ things to change.

@david-fortini
Copy link
Contributor Author

david-fortini commented Jan 30, 2022 •
edited
Loading

@finswimmer Just a ping, let me know if I should change something.

finswimmer
finswimmer approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. LGTM 👍

@finswimmer finswimmer merged commit b1f5f22 into python-poetry:master Jan 30, 2022
@finswimmer finswimmer mentioned this pull request Jul 5, 2022
Closed
3 tasks
@ddelange
Copy link

ddelange commented Nov 29, 2022

fwiw I added support for this pattern (e.g. google's infamous etils package which is required by jax) to pipgrip's vendored mixology in ddelange/pipgrip#101

@xhiroga xhiroga mentioned this pull request Apr 2, 2023
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Feb 29, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding a package with the same name as your local package results in an AssertionError

4 participants

@david-fortini @hagaivcita @finswimmer @ddelange