doc: change bash completions to user directory#3654
Closed
dlech wants to merge 6 commits intopython-poetry:masterfrom
Closed
doc: change bash completions to user directory#3654dlech wants to merge 6 commits intopython-poetry:masterfrom
dlech wants to merge 6 commits intopython-poetry:masterfrom
Conversation
This changes the recommendation for bash completions to install in the user's home directory instead of the global `/etc` which would require root access. The expression is exactly how bash completions looks for the directory. Comes from: https://github.com/scop/bash-completion/blob/9e98e2558c0625340013b123880ebb6bedc0d1b3/bash_completion#L2262 Also a section is added about how to dynamically add the completions instead of creating a static file and describes the pros and cons of doing it that way instead. Fixes python-poetry#2295
abn
requested changes
Mar 21, 2021
Co-authored-by: Arun Babu Neelicattu <[email protected]>
Co-authored-by: Arun Babu Neelicattu <[email protected]>
Author
|
Thanks for the review. I have made the requested changes. |
kasteph
approved these changes
Mar 29, 2021
Author
|
Anything else needed to get this merged? |
Author
|
Looks like this bitrotted and I don't feel like updating since it doesn't seem like it was ever going to be merged anyway. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the recommendation for bash completions to install in the user's home directory instead of the global
/etcwhich would require root access.The expression is exactly how bash completions looks for the directory. Comes from: https://github.com/scop/bash-completion/blob/9e98e2558c0625340013b123880ebb6bedc0d1b3/bash_completion#L2262
Also a section is added about how to dynamically add the completions instead of creating a static file and describes the pros and cons of doing it that way instead.
Fixes #2295
Pull Request Check List
Resolves: #issue-number-here