Skip to content

Comments

Migrate to the new version of Cleo#3618

Merged
sdispater merged 1 commit intomasterfrom
new-cleo
Feb 2, 2021
Merged

Migrate to the new version of Cleo#3618
sdispater merged 1 commit intomasterfrom
new-cleo

Conversation

@sdispater
Copy link
Member

@sdispater sdispater commented Jan 29, 2021

This PR changes the code base to migrate to the new, work in progress, version of Cleo which will help improve things in order to better implement some features planned for the 1.2 release.

The major changes are the following:

  • A new command loading system that make it possible to only load and execute the requested command without having to import any other command. This will help with performance issues when executing Poetry (note that a lot of changes must be done internally to improve performances further).
  • The sub command system has changed and now works by using namespaced commands to achieve the same thing.

@sdispater sdispater force-pushed the new-cleo branch 4 times, most recently from 6fc3f80 to 3d45a4e Compare January 29, 2021 22:10
@sdispater sdispater marked this pull request as ready for review January 29, 2021 23:03
@sdispater sdispater requested a review from a team January 29, 2021 23:04
@jules-ch jules-ch mentioned this pull request Jan 31, 2021
Closed
3 tasks
finswimmer
finswimmer approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

I recognize that you've started to use type hints instead of type comments. I've avoided this in my PRs regarding adding missing type hints, to make cherry-picking to the 1.1 easier. But I guess once this PR is merged, we should switch the type comments to type hints (with com2ann this seems to be quiet easy) for the sake of consistency.

I let it to you to merge this PR.

@sdispater
Copy link
Member Author

sdispater commented Feb 2, 2021

@finswimmer The master branch is already Python 3.6+ only so there is no reason not to use type hints, that's why I started introducing them.

And, yes, I plan on converting everything to type hints.

@sdispater sdispater merged commit 855bc88 into master Feb 2, 2021
@sdispater sdispater deleted the new-cleo branch February 2, 2021 11:30
@finswimmer finswimmer mentioned this pull request Feb 2, 2021
Merged
@GooseYArd
Copy link

GooseYArd commented Feb 6, 2021

This morning I noticed that "poetry env info -p" and "poetry env info --path" are failing with a stack trace; a bisect narrowed it down to this PR. I haven't had a chance to dig into it yet.

@sdispater sdispater mentioned this pull request Apr 23, 2021
Merged
@Jhraumg Jhraumg mentioned this pull request May 23, 2021
Closed
2 tasks
@sdispater sdispater mentioned this pull request Jul 30, 2021
Merged
2 tasks
@astrojuanlu astrojuanlu mentioned this pull request Dec 27, 2021
Closed
@dimbleby dimbleby mentioned this pull request May 21, 2022
Open
2 tasks
@brandon-leapyear brandon-leapyear mentioned this pull request Sep 7, 2022
Closed
1 task
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@finswimmer finswimmer finswimmer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdispater @GooseYArd @finswimmer