publish: print on failure, simplify logic#3549
Merged
neersighted merged 1 commit intopython-poetry:masterfrom Nov 14, 2021
Merged
publish: print on failure, simplify logic#3549neersighted merged 1 commit intopython-poetry:masterfrom
neersighted merged 1 commit intopython-poetry:masterfrom
Conversation
Member
|
This is pretty stale now. Would you be willing to rebase onto current |
Contributor
Author
|
Merged in master! |
Member
|
This is blocked by |
Should help with cases like python-poetry#3397 The existing tests in tests/publishing/test_uploader.py should verify that this doesn't cause regressions.
neersighted
approved these changes
Nov 14, 2021
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help with cases like #3397
The logic coalesces a couple things, so that we hit a single except clause
that prints "Uploading failed"
The existing tests in https://github.com/python-poetry/poetry/blob/master/tests/publishing/test_uploader.py
should verify that this doesn't cause regressions.