show --tree: stop ignoring --no-dev#3296
Merged
kasteph merged 2 commits intopython-poetry:masterfrom Oct 28, 2020
1ace:show-tree-no-dev
Merged
show --tree: stop ignoring --no-dev#3296kasteph merged 2 commits intopython-poetry:masterfrom 1ace:show-tree-no-dev
kasteph merged 2 commits intopython-poetry:masterfrom
1ace:show-tree-no-dev
Conversation
Signed-off-by: Eric Engestrom <[email protected]>
Fixes #3295 Signed-off-by: Eric Engestrom <[email protected]>
dsch
pushed a commit
to dsch/poetry
that referenced
this pull request
Apr 23, 2021
2 tasks
abn
pushed a commit
that referenced
this pull request
Apr 30, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #3295
I have tested this with the
pyproject.tomlfrom #3295 and it behaves as intended:I tried adding a formal test, but I wouldn't be surprised if I did something wrong as I'm only just discovering the poetry codebase 🙃
You can run the tests on the first commit and see that it fails, and that it passes after the second commit 👍