Handle non-editable packages with pth files#3210
Merged
sdispater merged 1 commit intopython-poetry:1.1from Oct 23, 2020
Merged
Conversation
When detecting installed packages, this change ensures that packages with .pth files are not incorrectly marked as editable. A package is considered editable only if at least one of the paths detected is not in the environment site. Resolves: python-poetry#3077
|
@abn, this works for me. Thanks. |
Member
Author
|
@python-poetry/triage can I get this one reviewed please? |
sdispater
approved these changes
Oct 23, 2020
This was referenced Oct 23, 2020
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When detecting installed packages, this change ensures that packages
with .pth files are not incorrectly marked as editable. A package is
considered editable only if at least one of the paths detected is
not in the environment site.
Resolves: #3077