Skip to content

Comments

add config option to force --always-copy parameter for virtualenv#3157

Merged
abn merged 1 commit intopython-poetry:masterfrom
finswimmer:issue-3134-symlink-venv
Oct 16, 2020
Merged

add config option to force --always-copy parameter for virtualenv#3157
abn merged 1 commit intopython-poetry:masterfrom
finswimmer:issue-3134-symlink-venv

Conversation

@finswimmer
Copy link
Member

@finswimmer finswimmer commented Oct 9, 2020 •
edited
Loading

virtualenv uses symlink to the interpreter when creating a venv. While this reduces space and runtime this might lead to unexpected results, when the interpreter to which the symlink points get upgraded.

This PR introduce a config option virtualenvs.options.always-copy. If setting to true the --always-copy parameter is added to virtualenv command on creating the venv.

To keep the current behavior as default, this option is set to false by default.

Pull Request Check List

Resolves: #3134

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer force-pushed the issue-3134-symlink-venv branch 2 times, most recently from 14e69f4 to a5ae42f Compare October 9, 2020 06:32
@finswimmer finswimmer marked this pull request as ready for review October 9, 2020 13:10
@finswimmer finswimmer requested a review from a team October 9, 2020 13:11
@ericriff ericriff mentioned this pull request Oct 9, 2020
Closed
@abn
Copy link
Member

abn commented Oct 10, 2020

@finswimmer LGTM. Althought, I am wondering if we should names psace this into something like virtualenvs.options.always-copy or smilar. I feel we will have more options to be exposed. Alternatively we can also consider supporting virtualenvs.options.*, boolean beign flags that simply get transfored to --<flag>. This will also enable us to support options like system-site etc.

@finswimmer
Copy link
Member Author

finswimmer commented Oct 10, 2020

Althought, I am wondering if we should names psace this into something like virtualenvs.options.always-copy or smilar. I feel we will have more options to be exposed.

Yes, this sounds like a good idea.

Alternatively we can also consider supporting virtualenvs.options.*, boolean beign flags that simply get transfored to --.

IMO that's a bit risky. I'm quite sure there will be people, who are able to create a config that will break poetry ;) So, we should carefully choose which flag we want to include.

@finswimmer finswimmer force-pushed the issue-3134-symlink-venv branch from e7280d7 to 50b3665 Compare October 10, 2020 18:52
@finswimmer
add config option to force --always-copy argument for virtualenv
5587ffd 
fix issue for showing all configs when options has more then two level
@finswimmer finswimmer force-pushed the issue-3134-symlink-venv branch from 50b3665 to 5587ffd Compare October 10, 2020 18:59
@abn abn merged commit cb34c3d into python-poetry:master Oct 16, 2020
This was referenced Oct 16, 2020
Closed
Closed
@sdispater sdispater mentioned this pull request Apr 23, 2021
Merged
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abn abn abn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Poetry links to python3 and not python3.x

2 participants

@finswimmer @abn