export: fix directory dependencies#3120
Closed
mrcljx wants to merge 2 commits intopython-poetry:masterfrom
Closed
Conversation
abn
reviewed
Oct 7, 2020
| markers = requirement.split(";", 1)[1].strip() | ||
| if markers: | ||
| line += "; {}".format(markers) | ||
| elif dependency.is_directory(): # pip doesn't support ` @ ` for directories |
Member
There was a problem hiding this comment.
I do not think this should be done, because directory dependencies can be PEP 517 dependencies, which means -e will fail.
Author
There was a problem hiding this comment.
I don't follow. Having a line foo @ some/path in requirements.txt will break pip install with ERROR: Invalid requirement: 'foo @ some/path'? Should the exporter accept a new PEP508 format option besides requirements.txt?
Member
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
pipdoesn't supportfoo @ some/path/foodirectory dependencies.Depends on #3118 (doesn't really depend on it, but will be in conflict), which is why this PR is in draft mode for now (and also includes the same changes).