export: restore -e for develop exports#3118
export: restore -e for develop exports#3118mrcljx wants to merge 4 commits intopython-poetry:masterfrom
Conversation
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Couple of issues here,
- I am not sure if
-eworks well for PEP 517 directory dependencies - I do not think the checks are correct for this, only directory dependencies and vcs dependencies support editable installs.
Shouldn't the user then have removed
Will make the change. |
I guess this was existing behaviour. The the difference is poetry can handle PEP 517 packages, so a user might have |
tests/utils/test_exporter.py
Outdated
|
|
||
| expected = """\ | ||
| foo @ git+https://github.com/foo/foo.git@123456 | ||
| -e foo @ git+https://github.com/foo/foo.git@123456 |
There was a problem hiding this comment.
Hmm, these are not marked as develop in the lock data above. This should not, be -e prefixed. I think there is a bug some place else. I wonder if python-poetry/poetry-core#98 is related?
There was a problem hiding this comment.
Ah, I felt like I saw a PR for this. I can wait for that to land and then rebase my change here.
There was a problem hiding this comment.
Would be great if you can test with that branch locally atleast to confirm this is the case. Else we will have to dig into it seperately.
There was a problem hiding this comment.
Verified that against that branch the tests don't need updating.
|
Converting to Draft until python-poetry/poetry-core#98 is landed. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
Pull Request Check List
The
linevariable containing-ewas consistently overwritten.