Fix #2658: Run all uninstalls serially#3095
Closed
PetterS wants to merge 1 commit intopython-poetry:masterfrom
Closed
Fix #2658: Run all uninstalls serially#3095PetterS wants to merge 1 commit intopython-poetry:masterfrom
PetterS wants to merge 1 commit intopython-poetry:masterfrom
Conversation
Member
|
@PetterS why not simply add a retry once if |
Contributor
Author
|
That just does not seem safe to me? 😕 The code we are using is not built for concurrent uninstalls and we don't know that simply retrying is safe. It is hard to know the state of the virtualenv after a race condition failure. Might work in practice though. |
Member
Contributor
Author
|
Cheers! Is a better solution, albeit a bit harder to test. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #2658
This is one way of fixing the issue. Most of the changes are to make this code testable.
@abn