Pass project name as --prompt for virtualenv#3057
Pass project name as --prompt for virtualenv#3057Tadaboody wants to merge 10 commits intopython-poetry:masterfrom
Conversation
Tadaboody
changed the title
|
@abn I think this is ready for review, how do we start the process? |
|
@abn Bumping again for review, also would appreciate a |
|
Definitely worthy 😉 Just haven't managed to get the time to get back to this. Will do so in the next day or so. |
poetry/config/config.py
Outdated
| return re.sub(r"{(.+?)}", lambda m: self.get(m.group(1)), value) | ||
| return re.sub( | ||
| r"{(.+?)}", | ||
| lambda m: self.get(m.group(1)) or "{{{key}}}".format(key=m.group(1)), |
There was a problem hiding this comment.
This lambda is getting difficult to read at first pass. I'd suggest to take encapsulate this into its own function.
There was a problem hiding this comment.
I think I extracted it well enough here, should I change something? I'd still like to get this merged (and stop worrying about conflicts with upstream)
Tadaboody
force-pushed
the
feature/virtualenv_prompt
branch
from
9ee16ff to
1fa80f6
Compare
Co-authored-by: Steph Samson <[email protected]>
Tadaboody
force-pushed
the
feature/virtualenv_prompt
branch
from
cba1eb2 to
e545f12
Compare
|
Hey, I've been fixing merge conflicts here and there and would love to get to merge this before it gets stale again, any chance this gets looked at? |
|
I would love to get this merged! @abn @stephsamson Please review this as soon as possible? |
|
Can I get this rebased please? Aologies for the delay in getting to this. |
|
Superseded by #5606. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
6 participants
Pull Request Check List
Resolves: #3055