Skip to content

Comments

env: enable usersite for system environments#3000

Merged
abn merged 1 commit intopython-poetry:masterfrom
abn:issue/2996
Sep 30, 2020
Merged

env: enable usersite for system environments#3000
abn merged 1 commit intopython-poetry:masterfrom
abn:issue/2996

Conversation

@abn
Copy link
Member

@abn abn commented Sep 29, 2020

Resolves: #2996

@abn abn added the kind/bug Something isn't working as expected label Sep 29, 2020
@abn abn added this to the 1.1 milestone Sep 29, 2020
@abn abn requested a review from a team September 29, 2020 19:54
@abn abn force-pushed the issue/2996 branch 2 times, most recently from b93fc83 to 7fdea65 Compare September 29, 2020 20:25
@sdispater
Copy link
Member

It seems that pip only falls back on the user path only if the default site-packages is not writable:

Defaulting to user installation because normal site-packages is not writeable

So, we could keep the same logic.

@abn
Copy link
Member Author

abn commented Sep 30, 2020

Yeah I thought about that. But this would mean explicit check. I guess we can localise the check just before we write the pth file.

@abn abn merged commit 1e8b327 into python-poetry:master Sep 30, 2020
@abn abn deleted the issue/2996 branch September 30, 2020 21:16
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editable install by user fails with permission error

2 participants