Fix: allow whitespace in list of extras for a package#2985
Fix: allow whitespace in list of extras for a package#2985abn merged 3 commits intopython-poetry:masterfrom
Conversation
tests/console/commands/test_init.py
Outdated
| def test_add_package_with_extras_and_whitespace(app): | ||
| command = app.find("init") | ||
| result = command._parse_requirements(["databases[postgresql, sqlite]"]) |
There was a problem hiding this comment.
| def test_add_package_with_extras_and_whitespace(app): | |
| command = app.find("init") | |
| result = command._parse_requirements(["databases[postgresql, sqlite]"]) | |
| def test_add_package_with_extras_and_whitespace(tester): | |
| result = tester._parse_requirements(["databases[postgresql, sqlite]"]) |
There was a problem hiding this comment.
It look like it must be test._command._parse_requirements ...
| requirement = requirement.strip() | ||
| extras = [] | ||
| extras_m = re.search(r"\[([\w\d,-_]+)\]$", requirement) | ||
| extras_m = re.search(r"\[([\w\d,-_ ]+)\]$", requirement) |
There was a problem hiding this comment.
The range of \s is to wide. I don't think supporting e.g. tab characters here.
There was a problem hiding this comment.
Hmm, I guess for this case it is fine (ish). For PEP 508, whitespace typically refers to "non-line breaking whitespace". That is narrowier than \s and but wider than . I doubt anyone is going to type in foo[a, \t b] 😏
finswimmer
force-pushed
the
issue-2980-whitspace-extra-list
branch
from
56bc7f5 to
cddbcad
Compare
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Issue talks about add command but the fix is in init command?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
This fix allows having whitespaces in the list of extras during
poetry add, e.g.poetry add databases[postgresql, sqlite].Pull Request Check List
Resolves: #2980