Skip to content

Comments

executor: fix incorrect return value#2981

Merged
finswimmer merged 1 commit intopython-poetry:masterfrom
abn:fix/executor-return-value
Sep 27, 2020
Merged

executor: fix incorrect return value#2981
finswimmer merged 1 commit intopython-poetry:masterfrom
abn:fix/executor-return-value

Conversation

@abn
Copy link
Member

@abn abn commented Sep 26, 2020

Seems we were relying on the implicit casting of boolean/int for the execute method.

@abn abn requested a review from a team September 26, 2020 19:43
@abn abn added this to the 1.1 milestone Sep 26, 2020
@finswimmer finswimmer merged commit 346da80 into python-poetry:master Sep 27, 2020
@abn abn deleted the fix/executor-return-value branch September 28, 2020 00:49
@sdispater sdispater mentioned this pull request Sep 30, 2020
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants