Skip to content

Comments

Add 'rc' to VERSION_REGEX#2978

Merged
abn merged 1 commit intopython-poetry:masterfrom
adawalli:awallis/version_fix
Sep 25, 2020
Merged

Add 'rc' to VERSION_REGEX#2978
abn merged 1 commit intopython-poetry:masterfrom
adawalli:awallis/version_fix

Conversation

@adawalli
Copy link
Contributor

The previous VERSION_REGEX string only checks for 'RC', however, the
latest RC submitted to the poetry project is '1.1.0rc1' which fails the
regex test for allowing installation of PREVIEW releases.

fixes: #2977

The previous VERSION_REGEX string only checks for 'RC', however, the
latest RC submitted to the poetry project is '1.1.0rc1' which fails the
regex test for allowing installation of PREVIEW releases.

fixes: python-poetry#2977
@adawalli
Copy link
Contributor Author

@abn any ideas why this failed - I tested on debian 2.7 and cannot reproduce - is there something wrong with the test?

@abn
Copy link
Member

abn commented Sep 25, 2020

Intermittent failure. Will re-run.

@abn abn merged commit fa0881d into python-poetry:master Sep 25, 2020
@sdispater sdispater mentioned this pull request Sep 30, 2020
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installer Installs PREVIEW release even when POETRY_PREVIEW=0

2 participants