Option to disable ssl verify (Poetry 1.1+)#2912
Closed
Celeborn2BeAlive wants to merge 9 commits intopython-poetry:masterfrom
Closed
Option to disable ssl verify (Poetry 1.1+)#2912Celeborn2BeAlive wants to merge 9 commits intopython-poetry:masterfrom
Celeborn2BeAlive wants to merge 9 commits intopython-poetry:masterfrom
Conversation
…s changes to poetry-core also...
…evelop Add tests for `trusted` option.
2 tasks
2 tasks
Contributor
|
Hey @Celeborn2BeAlive I've created a pull request to your fork that updates to the latest |
Contributor
Author
|
Hi @maayanbar13, thanks but you should probably submit your new PR directly here since I don't follow the issue anymore. I close this one to avoid duplicate. |
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #1556
I'm opening this new pull request to replace /pull/2473. It includes tests introduced by @maayanbar13.
To make tests pass, you also need a
poetry-corethat include the PR python-poetry/poetry-core#80.However I had some tests failing (
tests/packages/*) when using the PR on top ofpoetry-core/masterlike it is now, so I cherry picked the commit on top of[email protected]and ran the tests again, they pass on my setup (windows 10, python 3.7). I've made a branch on my own fork pointing to the cherry-picked commit https://github.com/Celeborn2BeAlive/poetry-core/tree/option-trusted-repository-1.0.0a9 if you want to test by yourself.Now I'm trying to run this version of poetry on a project that use the
trustedoption to install a package from a private internal index (that was working with /pull/2473 on top of 1.0.8), but I have an error related to the unverified https request so something seems broken, I will investigate in the next few days.