Skip to content

Comments

Display chosen repository name, not always PyPI, in publish command#2905

Merged
finswimmer merged 2 commits intopython-poetry:masterfrom
ariebovenberg:fix-private-repo-publish-display
Sep 15, 2020
Merged

Display chosen repository name, not always PyPI, in publish command#2905
finswimmer merged 2 commits intopython-poetry:masterfrom
ariebovenberg:fix-private-repo-publish-display

Conversation

@ariebovenberg
Copy link
Contributor

Pull Request Check List

Resolves: #2872

  • Added tests for changed code.
  • Updated documentation for changed code. -- not needed

The fix was discussed and approved in the issue #2872.

@ariebovenberg
Copy link
Contributor Author

Looks like there is an apparently unrelated test failure in tests / windows / 2.7.

Copy link
Member

@finswimmer finswimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks a lot.

@finswimmer finswimmer merged commit 223717b into python-poetry:master Sep 15, 2020
@sdispater sdispater mentioned this pull request Sep 18, 2020
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish prints "publishing to PyPI", even in case of private repository

2 participants