handle poetry init non-interactive dependencies#2899
handle poetry init non-interactive dependencies#2899finswimmer merged 5 commits intopython-poetry:masterfrom
Conversation
rotu
commented
Sep 10, 2020
rotu
commented
- in non-interactive mode, suppress "This command will guide you through..."
- in interactive mode, respect command line --dependency if the user chooses NO for "Would you like to define your main dependencies interactively?"
1. in non-interactive mode, suppress "This command will guide you through..." 2. in interactive mode, respect command line --dependency if the user chooses NO for "Would you like to define your main dependencies interactively?"
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution 👍
Just a minor change request.
And can you please also create a test for the non-interactive poetry init please?
fin swimmer
| if self.io.is_interactive(): | ||
| self.line("") |
There was a problem hiding this comment.
I'm not sure if we really need this self.line(""). I guess at least it can be placed directly after the last output above and we can avoid this second if-statement.
Same thing applies to line 183-184.
There was a problem hiding this comment.
It serves to separate the interactive output of _determine_requirements, so that would change the output. Still want the change?
rotu
force-pushed
the
interactive-prompt
branch
from
e128337 to
9c2c4ab
Compare
|
@finswimmer Any more actions needed from me? It looks like the check failed for mysterious reasons unrelated to my development. |
|
@rotu: Could you please rebase onto master and see what happens to the checks? |
|
@finswimmer, backmerged master |
|
@rotu: Thanks a lot. The tests passes now, but now we have a conflict. :( Can you please resolve it? Thanks a lot for your contribution! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
