info: enable PEP 517 fallback builds by default#2810
Merged
abn merged 1 commit intopython-poetry:masterfrom Aug 27, 2020
Merged
info: enable PEP 517 fallback builds by default#2810abn merged 1 commit intopython-poetry:masterfrom
abn merged 1 commit intopython-poetry:masterfrom
Conversation
This change ensures that PEP 517 fallback builds are enabled by default
for when metadata inspection and setup.{py,cfg} parsing fails. This is
required in order to ensure that package requirements are correctly
identified for packages beyond first level dependencies.
Resolves: python-poetry#2807
finswimmer
approved these changes
Aug 19, 2020
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
LGTM 👍
Because this changes default behavior I let it to @sdispater to merge.
3 tasks
Member
Author
|
Merging this for now. We can revert it later if this causes issues. |
Merged
Closed
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that PEP 517 fallback builds are enabled by default
for when metadata inspection and setup.{py,cfg} parsing fails. This is
required in order to ensure that package requirements are correctly
identified for packages beyond first level dependencies.
Resolves: #2807
Resolves: #2850