Respect virtualenvs.in-project setting, if .venv is found in project folder#2771
Merged
abn merged 7 commits intopython-poetry:masterfrom Sep 23, 2020
Merged
Conversation
abn
requested changes
Aug 5, 2020
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Couple of comments. Also, would be good to cover these cases in test cases to avoid any regression.
abn
requested changes
Aug 10, 2020
3 tasks
* update docs * add tests
finswimmer
force-pushed
the
issue-1770-in-project-setting
branch
from
868e822 to
72b88e3
Compare
Co-authored-by: Arun Babu Neelicattu <[email protected]>
abn
requested changes
Sep 22, 2020
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Minor suggestions. Otherwise looks good.
…re checking if .venv folder exists
abn
reviewed
Sep 22, 2020
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Missed the documentation in the last pass.
abn
approved these changes
Sep 23, 2020
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, when there is a folder called
.venvwithin the project folder,poetrywill use it as the path to the venv regardless whethervirtualenvs.in-projectis set totrueor not. This leads to confusions as described in #1770 and #2756.With this PR poetry will check if
virtualenvs.in-projectis set totrueif it finds a.venvfolder.Closes: #1770
Closes: #2756