Merged
Conversation
abn
approved these changes
Jul 21, 2020
This was referenced Jul 21, 2020
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds lock file versioning support in order to ease lock file changes transitions, like the one we will have when upgrading from
1.0to1.1.The versioning will have a compatibility system, close to semver. Basically if the lock file is newer but compatible version-wise, then only a warning will be displayed, prompting the user to upgrade Poetry or to relock the dependencies. However, if the lock file is not compatible version-wise, an error will be raised.
Pull Request Check List