inspection: use pep517 metadata build#2632
Merged
abn merged 2 commits intopython-poetry:masterfrom Jul 24, 2020
Merged
Conversation
abn
force-pushed
the
improve-inspection-info
branch
from
f23b52d to
3c5d98f
Compare
sdispater
reviewed
Jul 7, 2020
abn
force-pushed
the
improve-inspection-info
branch
from
3c5d98f to
d82962b
Compare
abn
force-pushed
the
improve-inspection-info
branch
4 times, most recently
from
37961b7 to
4a2712d
Compare
3 tasks
Member
Author
|
@sdispater bumping this once again with the proposed changes addressing your concerns |
This change replaces setup.py explicit execution in favour of pep517 metadata builds. In addition to improving handling of PEP 517 metadata builds, error handling when reading setup files have also been improved.
abn
force-pushed
the
improve-inspection-info
branch
from
4a2712d to
4250a5f
Compare
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces
setup.pyexecution in favour of pep517 metadata builds. The proposed approach executespep517.meta.buildinstead ofpython setup.py egg_info.This does not change the order of preference in the inspection flow for execution vs AST parsing. A build is only perfromed in cases where existing metadata inspection,
SetupReaderparsing etc returns an incomplete/unusablePackageInfoinstance or raisesPackageInfoError.The original proposal was made in #2296 by @finswimmer.
Closes: #2296
Resolves: #1900
Pull Request Check List