Fix #2597 by checking that the directory exists#2602
Fix #2597 by checking that the directory exists#2602abn merged 2 commits intopython-poetry:developfrom
Conversation
|
Will fix the Python 2.7 errors if this is reasonable. |
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
We can potentially make use of the site.addpackage() method here. See suggestions.
|
Did the suggested changes. I don't understand the code well enough to write really good tests here, I'm afraid. The test currently mocks |
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
See comments, you should not need to change existing tests since the functionality should remain the same. Additionally, you will need to add couple of new fixtures in the istalled repository fixture such that the following cases are also evaluated;
- Multiple lines in
.pthfile. - Executable in
.pthfile.
|
OK, I reverted the test file so you can see the error. |
|
@PetterS I have applied a few changes. The changes themselves work; but need to rework for compatibility and add test case for executable |
abn
force-pushed
the
fix_2597
branch
2 times, most recently
from
60b2a8a to
2978cbe
Compare
|
Thanks for fixing this! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
2 participants
Resolves: #2597