Add missing as_posix() calls#2582
Merged
abn merged 2 commits intopython-poetry:masterfrom Jun 28, 2020
Merged
Conversation
As PR python-poetry#2398 changed package.root_dir from str to Path, we need to call as_posix() to convert it to str before passing to os.path.join.
abn
requested changes
Jun 19, 2020
Member
abn
left a comment
abn
left a comment
There was a problem hiding this comment.
Might be better to drop the os.path.join usage altogether.
abn
approved these changes
Jun 28, 2020
Merged
3 tasks
3 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As PR #2398 changed package.root_dir from str to Path , we need to call
as_posix()to convert it tostrbefore passing toos.path.join. Otherwise, it raises'PosixPath' object has no attribute 'endswith'error on Python <3.6.Pull Request Check List
Resolves: #issue-number-here