Skip to content

Comments

Revert "get-poetry.py fallback to standard executables (#1878) (#2426)"#2544

Merged
sdispater merged 2 commits intomasterfrom
revert-changes-to-get-poetry-script
Jun 11, 2020
Merged

Revert "get-poetry.py fallback to standard executables (#1878) (#2426)"#2544
sdispater merged 2 commits intomasterfrom
revert-changes-to-get-poetry-script

Conversation

@sdispater
Copy link
Member

This reverts commit f812822.

The recent changes to the get-poetry.py script to select the appropriate Python executable seems to have broken the CI.

I tried to fix it but for some reason the CI on Windows broke for other reasons.

So, I prefer to revert this changes to ensure the CI works again.

I also changed the tests workflow to use the current branch/PR get-poetry.py script rather than the one on master to ensure that any change to it is tested.

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater merged commit fd1e56b into master Jun 11, 2020
@sdispater sdispater deleted the revert-changes-to-get-poetry-script branch June 11, 2020 08:10
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant