Option to disable ssl verify (Poetry 1.0.x)#2473
Option to disable ssl verify (Poetry 1.0.x)#2473Celeborn2BeAlive wants to merge 5 commits intopython-poetry:masterfrom
Conversation
Opened PR into |
|
@Celeborn2BeAlive , I've added some tests to your branch targeting |
|
Closing this one in favor of /pull/2912 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Pull Request Check List
Resolves: #1556
Here is a proposition to disable SSL verification that makes
poetryeasier to use in corporate environments.So unfortunately I started from
masterbecause the contributing guide https://python-poetry.org/docs/contributing/#how-to-contribute does not mention to start fromdevelop.I tried to reproduce the contrib on top of
developthis morning but I must admit I gave up after noticing that poetry now depends onpoetry-corehaving its own repository. I guess it would not be hard to add what's needed inpoetry-core, but since I don't know the codebase it takes me time walking in the debugger to understand what's going on. The exception I had frompoetry-corewas related to thetrustedfield I've added that is not recognized, so modifyingpoetry-schema.jsoninpoetryis not enough anymore, something must be done in the code and I didn't invastigated much. The commit I made on top ofdevelopis available on top of this other branch: https://github.com/Celeborn2BeAlive/poetry/commits/option-to-disable-ssl-verify-developAbout tests I had no clear idea how to test this feature automatically. I did manual tests on one of our internal project that depends on packages from a private and repository and it did work.
Finally I modified the documentation but had issues building it: the resulting website does not contain valid html and is basically just a subpart of the html of the official documentation. Is there another step to build the full website ?