Fix resolution of path, url and VCS dependencies#2398
Merged
Conversation
sdispater
added
area/solver
Merged
sdispater
added a commit
to python-poetry/poetry-core
that referenced
this pull request
Jun 5, 2020
msakai
added a commit
to msakai/poetry
that referenced
this pull request
Jun 19, 2020
As PR python-poetry#2398 changed package.root_dir from str to Path, we need to call as_posix() to it convert to str before passing to os.path.join.
msakai
added a commit
to msakai/poetry
that referenced
this pull request
Jun 19, 2020
As PR python-poetry#2398 changed package.root_dir from str to Path, we need to call as_posix() to convert it to str before passing to os.path.join.
abn
pushed a commit
that referenced
this pull request
Jun 28, 2020
Ensure path requirement is converted to posix string. Relates-to: #2398
abn
pushed a commit
to abn/poetry
that referenced
this pull request
Jul 20, 2020
Ensure path requirement is converted to posix string. Relates-to: python-poetry#2398
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #1757
This PR solves multiple issues related to the resolution and installation of path, url and VCS dependencies:
*constraint attached to them which could cause the resolver to choose other versions of the specified package in case of a conflict. This is solved by loading and setting the proper constraint during the resolution.