Git dependencies respect poetry.lock on install#2327
Git dependencies respect poetry.lock on install#2327wakemaster39 wants to merge 13 commits intopython-poetry:masterfrom
Conversation
|
There was a missing variable being passed in preventing me from getting master running locally in the new |
poetry/puzzle/provider.py
Outdated
| @classmethod | ||
| def _execute_setup(self): |
There was a problem hiding this comment.
It doesn't seem you are using the class itself. In this case it is better to use staticmethod:
| @classmethod | |
| def _execute_setup(self): | |
| @staticmethod | |
| def _execute_setup(): |
There was a problem hiding this comment.
this one wasn't me, I am not sure what to do here,
poetry/poetry/puzzle/provider.py
Line 329 in 9f93df1
Master is broken right now and this was my best way of fixing it without touching anything else.
poetry/puzzle/solver.py
Outdated
| lpkg = self.__find_git_locked_version(pkg) | ||
|
|
||
| if lpkg: | ||
| print("lpkg", lpkg.source_reference) |
|
@sdispater, could we have your attention in this PR? |
|
@wakemaster39 could you rebase this PR? |
|
@jihadik can you rework this on top of |
|
Sorry, @abn, not sure what do you mean. |
|
@jihadik branch off of |
|
@wakemaster39 there was a broader change that would fix this issue at #2327 this might get closed in favour of that one. Also, apologies for not responding to this earlier. Since the last comments, we have switched to using |
|
@wakemaster39 yes; I meant #2720 - copy-pasta! :) |
|
didn't push yet, but this is working again once #2722 is merged |
Delete unit test that was directly counter to the issue
Fix other random issue in master causing break
Installation respects lock file
|
Closing in favour of #3875. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
5 participants
Pull Request Check List
Resolves: #2325
There is no documentation change required (I think)