Fix non-compliant Git URL matching#2018
Merged
finswimmer merged 1 commit intopython-poetry:masterfrom Feb 11, 2020
Merged
Conversation
RFC 3986 § 2.3 permits more characters in a URL than were matched. This corrects that, though there may be other deficiencies. This was a regression from v1.0.2, where at least “.” was matched without error.
amarshall
force-pushed
the
fix-git-url-pattern
branch
from
beac194 to
7348893
Compare
finswimmer
approved these changes
Feb 11, 2020
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution! 👍
Good to know there is a RFC about this :)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 3986 § 2.3 permits more characters in a URL than were matched. This corrects that, though there may be other deficiencies. This was a regression from v1.0.2, where at least “.” was matched without error.
Specifically, this had failed for us upon upgrading to v1.0.3 for a Git URL whose path contained akin to “foo.bar.git”.