Skip to content

Comments

#1393 Add system site-packages support in virtualenv (again)#1982

Closed
kam1sh wants to merge 2 commits intopython-poetry:masterfrom
kam1sh:1393-system-site-packages-2
Closed

#1393 Add system site-packages support in virtualenv (again)#1982
kam1sh wants to merge 2 commits intopython-poetry:masterfrom
kam1sh:1393-system-site-packages-2

Conversation

@kam1sh
Copy link
Contributor

@kam1sh kam1sh commented Feb 5, 2020 •
edited
Loading

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.
  • Fixed existing tests (on my machine)
  • Fixed existing tests (in CI)
  • Added logging for changed code

Looks like I really like Poetry, because I'm sumbitting this PR again (previous is #1404). But now I decided to rename setting from virtualenvs.include-system-packages to just virtualenvs.system-packages. I hope it could be merged now at least...

If you think there is a lack in something in this PR, just say and I'll do my best. I have enough spare time to dig in Poetry code base & tests =)

Conan-Kudo
Conan-Kudo previously approved these changes Feb 9, 2020
View reviewed changes
@finswimmer finswimmer added kind/feature Feature requests/implementations area/venv Related to virtualenv management labels Feb 10, 2020
@four43
Copy link

four43 commented Feb 19, 2020

This will be great for working with conda to install scientific packages, then using poetry to do the rest.

@etijskens
Copy link

etijskens commented Feb 19, 2020 via email

@rnc rnc mentioned this pull request Jul 1, 2020
Open
4 tasks
@samvasko samvasko mentioned this pull request Jul 7, 2020
Closed
2 tasks
@wyl8899 wyl8899 mentioned this pull request Jul 19, 2020
Closed
2 tasks
@etijskens
Copy link

etijskens commented Sep 28, 2020

many thanks!

@abn abn changed the base branch from develop to master October 16, 2020 12:59
@abn abn dismissed Conan-Kudo’s stale review October 16, 2020 12:59

The base branch was changed.

@abn
Copy link
Member

abn commented Oct 16, 2020

Apoligies for dropping the ball on this one. Feel free to ping on discord if something falls through the crack again. We appricate your contributions, issues reports, PRs and doc fixes alike.

For this particular change, is it possible to get this rebased against master and aligned with what has been merged in #3157 using the virtualenvs.options namespace?

@etijskens
Copy link

etijskens commented Jan 22, 2021

can anybody tell me the status of this feature?
I would like to use poetry on a supercomputer, where not using system site packages is an absolute no go. The system site packages are compiled with special care for performances issues.

@sinoroc
Copy link

sinoroc commented Jan 22, 2021

I would like to use poetry on a supercomputer, where not using system site packages is an absolute no go. The system site packages are compiled with special care for performances issues.

A different approach to this:
Why not package those custom-compiled dependencies as wheels and distribute them via a custom index repository?

@vlad0337187 vlad0337187 mentioned this pull request Feb 20, 2021
Merged
@vlad0337187
Copy link
Contributor

vlad0337187 commented Feb 20, 2021

@abn, fixed this in PR, could you review please ?

@abn abn closed this in #3711 Mar 21, 2021
@abn abn mentioned this pull request Mar 21, 2021
Merged
@ClementWalter
Copy link

ClementWalter commented Apr 20, 2021

is this released yet? Would really appreciate to use the feature

@vlad0337187
Copy link
Contributor

vlad0337187 commented Apr 21, 2021

@ClementWalter , no it wasn't released yet.
But you can install it from GitHub directly:
pipx install git+https://github.com/python-poetry/poetry.git

@vlad0337187 vlad0337187 mentioned this pull request May 2, 2021
Closed
3 tasks
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Conan-Kudo Conan-Kudo Conan-Kudo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/venv Related to virtualenv management kind/feature Feature requests/implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kam1sh @four43 @etijskens @abn @sinoroc @vlad0337187 @ClementWalter @Conan-Kudo @finswimmer