get-poetry.py fallback to standard executables#1878
Merged
sdispater merged 7 commits intopython-poetry:developfrom May 14, 2020
Merged
get-poetry.py fallback to standard executables#1878sdispater merged 7 commits intopython-poetry:developfrom
sdispater merged 7 commits intopython-poetry:developfrom
Conversation
Contributor
Author
|
adjusts #1668 |
jonapich
commented
Jan 13, 2020
Contributor
Author
jonapich
left a comment
jonapich
left a comment
There was a problem hiding this comment.
Should this point to master instead, and be released a bug fix?
Contributor
Author
|
I'd like to change the behavior further if you'll let me. I think the new This python/python3 setup seems to be standard in Ubuntu16 and Ubuntu18 at the least. |
frankier
reviewed
Jan 22, 2020
sdispater
pushed a commit
that referenced
this pull request
May 15, 2020
* get-poetry.py fallback to standard executables * documentation update * fix typo due to cleanup * favor python3 over python2 when creating launcher * launcher favors 3.5 and up, else the first valid one it finds. * favor any py3 over py2, not just 3.5+ Co-authored-by: Jonathan Piché <[email protected]>
This was referenced May 15, 2020
This was referenced May 28, 2020
3 tasks
sdispater
added a commit
that referenced
this pull request
Jun 10, 2020
* get-poetry.py fallback to standard executables * documentation update * fix typo due to cleanup * favor python3 over python2 when creating launcher * launcher favors 3.5 and up, else the first valid one it finds. * favor any py3 over py2, not just 3.5+ Co-authored-by: Jonathan Piché <[email protected]> Co-authored-by: Jonathan Piché <[email protected]> Co-authored-by: Jonathan Piché <[email protected]>
2 tasks
sdispater
added a commit
that referenced
this pull request
Jun 10, 2020
sdispater
added a commit
that referenced
this pull request
Jun 10, 2020
sdispater
added a commit
that referenced
this pull request
Jun 11, 2020
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't sure how to spin new tests here; I believe the get-poetry.py script isn't part of the test suite, is that possible?
This makes the installation more flexible by allowing
python3on linux (whenpythoncannot be found; typical in a lot of 2 -> 3 migration scenarios).On windows, we add some basic support for PEP 397 by leveraging the
py.exelauncher. Since Windows uses the .bat file to launch the .py file, I removed the shebang from the windows launcher so that we don't end up writing/usr/bin/env py.exe -3😅fixes #1877