Properly propagate dependency markers#1829
Merged
Conversation
kasteph
approved these changes
Jan 10, 2020
Member
kasteph
left a comment
There was a problem hiding this comment.
This PR looks good, just one comment I have below which is more of a question :)
5 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This PR fixes the propagation of environment markers for dependencies. Before this change, the environment markers where not properly propagated which could cause false reports of incompatibilities. For instance, if you had the
blackdependency with thepython_version >= '3.6' and implementation_name != 'pypy'environment marker, the resolution would fail with the following message:This is obviously wrong since we specified
python_version >= '3.6'but the marker was lost during the resolution.I took this opportunity to improve the way we handle markers to avoid producing markers that are obviously wrong or that can't be satisfied.