Fix PEP440 compatible release (~=) handling#1815
Merged
sdispater merged 2 commits intopython-poetry:masterfrom Jan 6, 2020
Merged
Fix PEP440 compatible release (~=) handling#1815sdispater merged 2 commits intopython-poetry:masterfrom
~=) handling#1815sdispater merged 2 commits intopython-poetry:masterfrom
Conversation
PEP440 compatible release version range (`~=`) should have itself as a minimum value. Examples from [official doc](https://python.org/dev/peps/pep-0440/#compatible-release) (each pair is equivalent): ``` ~=2.2 >=2.2, ==2.* ~=1.4.5 >=1.4.5, ==1.4.* ~=2.2.post3 >=2.2.post3, ==2.* ~=1.4.5a4 >=1.4.5a4, ==1.4.* ``` In every case, lower bound is exactly same as the input version. Current incorrect behavior was originally introduced 2 years ago by commit c55d55a, where it tried to reset patch version to 0 for tilde expression. Closes python-poetry#1150.
finswimmer
approved these changes
Jan 2, 2020
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Looks good to me 👍 Thanks a lot!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP440 compatible release version range (
~=) should have itself as a minimum value. Examples from official doc (each pair is equivalent):In every case, lower bound is exactly same as the input version including
restandprebut current behavior drop other than major, minor and patch. Current incorrect behavior was originally introduced 2 years ago by commit c55d55a, where it tried to reset patch version to 0 for tilde expression, and hasn't been fixed by #1481, which only added up to patch version.Closes #1150