create valid PEP508 string for git dependencies with ssh (#1697)#1799
create valid PEP508 string for git dependencies with ssh (#1697)#1799sdispater merged 1 commit intopython-poetry:masterfrom
Conversation
finswimmer
added
kind/bug
| @@ -1,3 +1,5 @@ | |||
| from poetry.vcs import git | |||
There was a problem hiding this comment.
| from poetry.vcs import git | |
| from ...vcs import git |
There was a problem hiding this comment.
Hello @matemax,
I'm not a big fan of relative imports. "Explicit is better than implicit." and is better to read. Absolute imports are also used (most if the time) in the poetry code.
There was a problem hiding this comment.
Hello @finswimmer ,
It is a suggestion. I try use these code for me and noticed relative and not relative import in one file.
There was a problem hiding this comment.
The rule I have personally is if the import comes from the same module/package, it should be a relative import otherwise it should be an absolute import. An example of this is https://github.com/python-poetry/poetry/blob/master/poetry/masonry/builders/builder.py
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Fixes: #1697
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!