fix (setup_reader): parse arguments when setuptools.setup() is used (#1761)#1764
Merged
sdispater merged 3 commits intopython-poetry:masterfrom Dec 20, 2019
Merged
Conversation
…lled by `setuptools.setup()`
brycedrennan
approved these changes
Dec 19, 2019
sdispater
approved these changes
Dec 20, 2019
shenek
pushed a commit
to shenek/poetry
that referenced
this pull request
Dec 31, 2019
…ython-poetry#1761) (python-poetry#1764) * fix (setup_reader): in `setup.py` the `setup()` method can also be called by `setuptools.setup()` * fix (setup_reader): make black happy * fix (setup_reader): skip test for python <3.4
5 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment the parser expect that the setup method in
setup.pyis called withsetup()only and will fail ifsetuptools.setup()is used instead. This PR fixes it.Fixes: #1761
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!