Skip to content

Comments

fix: change self:uninstall to self uninstall in get-poetry.py#1722

Merged
brycedrennan merged 1 commit intopython-poetry:masterfrom
finswimmer:issue-01720-self-uninstall
Dec 13, 2019
Merged

fix: change self:uninstall to self uninstall in get-poetry.py#1722
brycedrennan merged 1 commit intopython-poetry:masterfrom
finswimmer:issue-01720-self-uninstall

Conversation

@finswimmer
Copy link
Member

Fixes: #1720

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

@finswimmer finswimmer added the area/docs Documentation issues/improvements label Dec 13, 2019
@finswimmer finswimmer mentioned this pull request Dec 13, 2019
3 tasks
Copy link
Contributor

@brycedrennan brycedrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@brycedrennan brycedrennan merged commit a7792f6 into python-poetry:master Dec 13, 2019
@sdispater
Copy link
Member

Now that I think about it, the self uninstall command was never implemented (due to issues on Windows), so I wonder if we should just remove mentions to it until we actually go with the implementation. 

@finswimmer
Copy link
Member Author

If it isn't implemented it should be removed 🗑️ 😀

@finswimmer finswimmer deleted the issue-01720-self-uninstall branch December 13, 2019 18:04
shenek pushed a commit to shenek/poetry that referenced this pull request Dec 31, 2019
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/docs Documentation issues/improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install script details old API

3 participants