Skip to content

Comments

Removing setecho(False) for all shells#1673

Merged
sdispater merged 2 commits intopython-poetry:masterfrom
jmaroeder:fix/no-echo-in-shell
Dec 24, 2019
Merged

Removing setecho(False) for all shells#1673
sdispater merged 2 commits intopython-poetry:masterfrom
jmaroeder:fix/no-echo-in-shell

Conversation

@jmaroeder
Copy link
Contributor

@jmaroeder jmaroeder commented Dec 4, 2019 •
edited
Loading

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Intended to fix #1672. It appears to me that the only thing that the setecho(False) line does is prevent a double echo of the /bin/activate command in zsh.

Example outputs

Example outputs from various shells. Note that the only things actually typed here are the initial poetry shell and the final exit:

fish

$ poetry shell
Spawning shell within <REDACTED>/.venv
$ source <REDACTED>/.venv/bin/activate.fish
$ exit

bash

bash-3.2$ poetry shell
Spawning shell within <REDACTED>/.venv

The default interactive shell is now zsh.
To update your account to use zsh, please run `chsh -s /bin/zsh`.
For more details, please visit https://support.apple.com/kb/HT208050.
bash-3.2$ . <REDACTED>/.venv/bin/activate
(.venv) bash-3.2$ exit

zsh

% poetry shell
Spawning shell within <REDACTED>/.venv
. <REDACTED>/.venv/bin/activate
% . <REDACTED>/.venv/bin/activate
(.venv) % exit

@jmaroeder
Copy link
Contributor Author

jmaroeder commented Dec 4, 2019

Note that the above tests were performed in MacOS.

@itsthejoker
Copy link

itsthejoker commented Dec 17, 2019

I can confirm this fix works for me and makes poetry usable again on fish shell. @sdispater please take a look at this PR -- this fixes #1672 and #1664. Cheers!

sdispater
sdispater requested changes Dec 20, 2019
View reviewed changes
@finswimmer finswimmer added the kind/bug Something isn't working as expected label Dec 23, 2019
@sdispater sdispater merged commit db6db8f into python-poetry:master Dec 24, 2019
@sdispater
Copy link
Member

sdispater commented Dec 24, 2019

Thanks!

@itsthejoker itsthejoker mentioned this pull request Dec 27, 2019
Closed
4 tasks
shenek pushed a commit to shenek/poetry that referenced this pull request Dec 31, 2019
@jmaroeder @shenek
Removing setecho(False) for all shells (python-poetry#1673)
fc55f2e 
* Removing setecho(False) for all shells

* Only setecho(False) for zsh
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
Closed
5 tasks
@jmaroeder jmaroeder deleted the fix/no-echo-in-shell branch January 12, 2020 00:54
@github-actions
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sdispater sdispater sdispater approved these changes

Assignees

No one assigned

Labels

kind/bug Something isn't working as expected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

poetry shell with fish does not echo in python REPL

4 participants

@jmaroeder @itsthejoker @sdispater @finswimmer