Set mtime on setup.py/PKG-INFO when building sdist#1541
Merged
finswimmer merged 1 commit intopython-poetry:masterfrom Nov 21, 2019
Merged
Set mtime on setup.py/PKG-INFO when building sdist#1541finswimmer merged 1 commit intopython-poetry:masterfrom
finswimmer merged 1 commit intopython-poetry:masterfrom
Conversation
Previously, the mtime was the default value of 0. Fixes python-poetry#670. This stops the following warning when using gnu tar: implausibly old time stamp 1970-01-01 01:00:00
finswimmer
approved these changes
Nov 21, 2019
Member
finswimmer
left a comment
finswimmer
left a comment
There was a problem hiding this comment.
Thank you very much! Looks good to me 🚀
1 task
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fix
Previously, the
mtimeofsetup.pyandPKG-INFOwas the default value of 0, which showed that the files were last modified on Jan 1st 1970.This created the following warning when using gnu tar:
implausibly old time stamp 1970-01-01 01:00:00This commit sets the last modified time of
setup.pyandPKG-INFOto the time they are created, and tests that every file in thesdisttar.gzhas a valid (i.e. greater than 0)mtime.Fixes #670.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the
developbranch. If it's a bug fix or only a documentation update, it should be based on themasterbranch.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!