Add system-site-packages setting#1404
Add system-site-packages setting#1404kam1sh wants to merge 1 commit intopython-poetry:developfrom kam1sh:1393-system-site-packages
Conversation
|
Thanks for your PR @kam1sh 🍡 💫 I think this is a good idea and is a great feature to have 💪 would you mind fixing the checks that cause this build to fail? |
|
Sure! I just was too lazy to implement this for Python 2.7 =) |
|
I think it's ready. |
|
Thanks @kam1sh! Sorry but one more thing, can you squash the commits into one? |
|
I thought it can be done on PR merge... |
|
Absolutely, but maybe you yourself would want to create a descriptive commit message :) |
|
You will need to update the |
|
Forgot to check it in the Poetry CLI itself, thank you. |
|
Now it shows in > poetry config --list
...
virtualenvs.include-system-packages = false
...What's next? Maybe I should mock environment creation in tests? Or write tests for command |
|
Hello? I have to write more tests/code or feature is ready to merge? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Well, I see that no one wants this PR. Fine =( |
|
@stephsamson @kam1sh can you please consider reviving this PR? What is the additional work required to merge? Some of us are willing to help, see #1393. |
|
Hello, this is very useful for packages that that are distributed using apt on ARM. I would really appreciate this getting merged. @kam1sh Your PR looks great and It would be a shame for the work to go to waste. Could you please reopen it so we can pester people to merge it in. |
|
I too would really appreciate if this gets merged. |
|
I agree this functionality would be useful in Poetry, but for the meantime here are some workarounds (cross-posting across related issues): Use case 1) I just want to save space use by my virtualenvs:
Use case 2) I need to use a globally installed package from my poetry venv.
|
|
This would be helpful in cases where some developer uses their own debugging modules via |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes #1393
Pull Request Check List
I'm not sure is practice using
system-site-packagesis good or bad, but ifvenvmodule supports that, I think poetry should support it too as it manages virtual environments.